Skip to content

pass branch into count call #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 24, 2025
Merged

pass branch into count call #482

merged 2 commits into from
Jul 24, 2025

Conversation

@ajtmccarty
Copy link
Contributor

@ajtmccarty ajtmccarty commented Jul 23, 2025 •
edited by coderabbitai bot
Loading

we were missing the branch argument here

Summary by CodeRabbit

  • Bug Fixes
    • Improved accuracy of node counts during batch processing by ensuring branch context is respected in filters.

@coderabbitai
Copy link

coderabbitai bot commented Jul 23, 2025 •
edited
Loading

Walkthrough

The update modifies internal calls to the count method within the filters methods of both asynchronous and synchronous clients, ensuring the branch parameter is now explicitly passed. This change ensures batch processing respects the branch context when counting nodes for pagination. No public API or function signatures are changed.

Changes

File(s) Change Summary
infrahub_sdk/client.py Added explicit branch parameter to internal count method calls within batch processing logic.
changelog/+branch-in-count.fixed.md Documented the addition of the branch parameter to count calls for correct branch context.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f5e3b69 and 7876f13.

📒 Files selected for processing (1)
  • changelog/+branch-in-count.fixed.md (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • changelog/+branch-in-count.fixed.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: unit-tests (3.12)
  • GitHub Check: unit-tests (3.10)
  • GitHub Check: unit-tests (3.9)
  • GitHub Check: unit-tests (3.11)
  • GitHub Check: unit-tests (3.13)
  • GitHub Check: integration-tests-latest-infrahub
  • GitHub Check: Cloudflare Pages
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ajtm-0723205-branch-in-count
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary or Summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 23, 2025 •
edited
Loading

Deploying infrahub-sdk-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7876f13
Status: ✅  Deploy successful!
Preview URL: https://6310d11a.infrahub-sdk-python.pages.dev
Branch Preview URL: https://ajtm-0723205-branch-in-count.infrahub-sdk-python.pages.dev

View logs

@codecov
Copy link

codecov bot commented Jul 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

@@            Coverage Diff             @@
##           stable     #482      +/-   ##
==========================================
- Coverage   75.74%   75.67%   -0.08%     
==========================================
  Files         100      100              
  Lines        8841     8789      -52     
  Branches     1736     1721      -15     
==========================================
- Hits         6697     6651      -46     
+ Misses       1665     1661       -4     
+ Partials      479      477       -2
Flag Coverage Δ
integration-tests 34.85% <50.00%> (-0.07%) ⬇️
python-3.10 47.94% <100.00%> (-0.23%) ⬇️
python-3.11 47.96% <100.00%> (-0.23%) ⬇️
python-3.12 47.92% <100.00%> (-0.23%) ⬇️
python-3.13 47.92% <100.00%> (-0.25%) ⬇️
python-3.9 46.63% <100.00%> (-0.16%) ⬇️
python-filler-3.12 25.23% <0.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/client.py 69.48% <100.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

dgarros
dgarros approved these changes Jul 24, 2025
View reviewed changes
Copy link
Contributor

@dgarros dgarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, please can you add a changelog

@dgarros dgarros merged commit 16da1ba into stable Jul 24, 2025
20 checks passed
@dgarros dgarros deleted the ajtm-0723205-branch-in-count branch July 24, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgarros dgarros dgarros approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ajtmccarty @dgarros